Proxy password with @ symbol not parsed/saved correctly
By chrisjaq... on April 19, 2012 09:23 (imported from Google Code)
When setting the proxy password from the settings menu, if the password contains strange symbols (such as the @ sign, etc) it is not passed correctly to the underlying bash/git environment (I assume). I can work around this issue by replacing the @ symbol with the bash equivalent (%40 for @) as if I were manually entering the password at a shell prompt but it is not obvious this needs to be done.
What steps will reproduce the problem?
- Right-click in explorer -> TortoiseGit -> Settings -> Network
- Enable proxy server with
Server address: "proxy.company.com"
Port: "3128"
Username: "MyName"
Password: "MyP@ssword" - Apply -> Okay
- Clone a repository (which will fail with an http error).
What is the expected output?
Repository is cloned successfully.
What do you see instead?
When going back to the network settings I see the following:
Server address: "ssword@proxy.company.com"
Port: "3128"
Username: "MyName"
Password: "***" (which I assume is "MyP")
What version of the product are you using? On what operating system?
TortoiseGit 1.7.8.0
git version 1.7.10.msysgit.1
on Windows 7 x64
Please provide any additional information below.
If I enter the password as "MyP%40ssword" everything works correctly so I assume that special characters for bash (@, #, $, etc.) need to be replaced with their % equivalents. So is it possible to automatically parse the provided password and replace it with its bash-friendly equivalent?
Thanks for a great shell extension, it is very useful. Let me know if I can provide any further information.